Basic support for DataContext={resource: ...} #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exyi
force-pushed
the
resource-datacontext
branch
2 times, most recently
from
bcdd52d to
e885da2
Compare
exyi
force-pushed
the
resource-datacontext
branch
from
d99fb15 to
dca0a1b
Compare
exyi
force-pushed
the
resource-datacontext
branch
from
a9193f7 to
2fa5063
Compare
exyi
force-pushed
the
resource-datacontext
branch
2 times, most recently
from
efbaf1e to
3ee2344
Compare
exyi
force-pushed
the
resource-datacontext
branch
from
3ee2344 to
14a7721
Compare
exyi
added a commit
that referenced
this pull request
Dec 7, 2022
problem was that that BindingHelper.FindDataContextTarget assumed there was one more data context layer since we used set data context type and DataContext on different controls. Because of that command client-side and server-side data context paths didn't match. Technically, this is a glitch of BindingHelper, not HierarchyRepeater, but "fixing" BindingHelper will break many things and it's hopefully going to be done in #1392
exyi
added a commit
that referenced
this pull request
Dec 7, 2022
problem was that that BindingHelper.FindDataContextTarget assumed there was one more data context layer since we used set data context type and DataContext on different controls. Because of that command client-side and server-side data context paths didn't match. Technically, this is a glitch of BindingHelper, not HierarchyRepeater, but "fixing" BindingHelper will break many things and it's hopefully going to be done in #1392
exyi
added a commit
that referenced
this pull request
Dec 21, 2022
problem was that that BindingHelper.FindDataContextTarget assumed there was one more data context layer since we used set data context type and DataContext on different controls. Because of that command client-side and server-side data context paths didn't match. Technically, this is a glitch of BindingHelper, not HierarchyRepeater, but "fixing" BindingHelper will break many things and it's hopefully going to be done in #1392
exyi
added a commit
that referenced
this pull request
Jan 4, 2023
Part is taken from #1392 which won't be merged for a while.
exyi
added a commit
that referenced
this pull request
Feb 1, 2023
Part is taken from #1392 which won't be merged for a while.
exyi
force-pushed
the
resource-datacontext
branch
from
14a7721 to
dd7cf40
Compare
This functionality is essential for server-side only rendering, but this patch is only the groundwork - we still need to add support to Repeater and possibly other controls. The design is fairly simple - we allow resource binding in data context and track that this data context does not exist client-side (see the new ServerSideOnly property). Using this server-only data context is not allowed in value and staticCommand bindings. Note that using a value binding inside the resource-bound control is allowed, it just cannot reference `_this`. Since the context does not exist client-side, we then translate _parent into $data instead of $parent.
exyi
force-pushed
the
resource-datacontext
branch
from
dd7cf40 to
36f7055
Compare
exyi
force-pushed
the
resource-datacontext
branch
from
88d7168 to
3019446
Compare
* ExpectedType property can now be null, when the assigned property is unknwon:
- this means that CreateBinding will actually create a strongly
typed instance, instead of just ValueBindingExpression<object> or similar
* AutoUI uses props.Property instead of CreateValueBinding where possible
exyi
force-pushed
the
resource-datacontext
branch
from
e7708ec to
10002de
Compare
…property This avoids being too sensitive to the DataContextType property, which is often set incorrectly in our libraries (to hack around other issues, so not easily fixed). We therefore switch the IsServerSideOnly check to another dedicated property which needs to be set by Repeater and similar controls. This means that DataContext=resource compatibility will need some non-obvious hack, but code which doesn't do that will not be affected by the update to v5 in any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality allows server-only rendering - i.e. building static HTML based on viewmodel which is not necessarily sent to the client.
The design is fairly simple - we allow resource binding
in data context and track that this data context does
not exist client-side (see the new
ServerSideOnlyproperty).Using this server-only data context is not allowed in value
and
staticCommandbindings. Note that using a value bindinginside the resource-bound control is allowed, it just cannot
reference
_this. Since the context does not exist client-side,we then translate
_parentinto$datainstead of$parent.Repeater, GridView and HierarchyRepeater should all support this.